fix: fix annotated typing#1692
Merged
Merged
Conversation
KelvinChung2000
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 23 23
Lines 5678 5681 +3
=======================================
+ Hits 5655 5658 +3
Misses 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
tleonhardt
reviewed
Jun 11, 2026
tleonhardt
reviewed
Jun 11, 2026
|
I check out this PR. It works for me. Thank you very much! |
Address review feedback on PR #1692: - Remove forward-reference quotes from _WithAnnotatedDecorator.__call__ since Callable, _CommandParams, and _CommandReturn are already in scope - Add a Bug Fixes changelog entry for the with_annotated type-hint fix
tleonhardt
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1684